Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable BedrockModel to be imported directly from phoenix.evals.models sub-module #1695

Merged
merged 1 commit into from
Nov 1, 2023
Merged

fix: enable BedrockModel to be imported directly from phoenix.evals.models sub-module #1695

merged 1 commit into from
Nov 1, 2023

Conversation

axiomofjoy
Copy link
Contributor

@axiomofjoy axiomofjoy commented Nov 1, 2023 •
edited
Loading

Adds the ability for the user to import BedrockModel in the following manner

from phoenix.experimental.evals.models import BedrockModel

in keeping with other model types.

mikeldking
mikeldking approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@mikeldking mikeldking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the PR title a bit more release note friendly?

@axiomofjoy axiomofjoy changed the title fix: add bedrock import fix: enable BedrockModel to be imported directly from phoenix.evals.models sub-module Nov 1, 2023
@axiomofjoy axiomofjoy merged commit dc7f3ef into main Nov 1, 2023
13 checks passed
@axiomofjoy axiomofjoy deleted the add-bedrock-import branch November 1, 2023 18:28
@github-actions github-actions bot mentioned this pull request Nov 1, 2023
Merged
@github-actions github-actions bot mentioned this pull request Feb 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeldking mikeldking mikeldking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
phoenix
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axiomofjoy @mikeldking